[webkit-reviews] review granted: [Bug 109350] Resource leak related to gstreamer and videos : [Attachment 208252] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 9 11:13:37 PDT 2013


Eric Carlson <eric.carlson at apple.com> has granted  review:
Bug 109350: Resource leak related to gstreamer and videos
https://bugs.webkit.org/show_bug.cgi?id=109350

Attachment 208252: Patch
https://bugs.webkit.org/attachment.cgi?id=208252&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=208252&action=review


>>> Source/WebCore/html/HTMLMediaElement.cpp:4183
>>> +	 m_player.clear();
>> 
>> This is unnecessary. Earlier in this method we called userCancelledLoad(),
which called clearMediaPlayer(), which called m_player.clear().
> 
> Only if the media file is not fully loaded. If the file is fully loaded
userCancelledLoad() does nothing.

True enough. It might be worth noting this in your comment so someone doesn't
"optimize" it away at some point in the future.


More information about the webkit-reviews mailing list