[webkit-reviews] review granted: [Bug 94345] [Qt][WK2] Accelerated compositing example with links being animated crashes tap highlight : [Attachment 208418] Patch

[bugzilla-daemon at webkit.org]

Jocelyn Turcotte <jocelyn.turcotte at digia.com> has granted Allan Sandfeld Jensen
<allan.jensen at digia.com>'s request for review:
Bug 94345: [Qt][WK2] Accelerated compositing example with links being animated
crashes tap highlight
https://bugs.webkit.org/show_bug.cgi?id=94345

Attachment 208418: Patch
https://bugs.webkit.org/attachment.cgi?id=208418&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at digia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=208418&action=review


> Source/WebCore/ChangeLog:3
> +	   [Qt][WK2] Accelerated compositing example with links being animated
crashes tap highlight

The Qt style bot will complain downstream, "Accelerated compositing" -> "AC"
would help :P

> Source/WebCore/page/GestureTapHighlighter.cpp:227
> +		   if (ringQuad.isRectilinear())
> +		       ringRect = ringQuad.enclosingBoundingBox();
> +		   else
> +		       ringRect = LayoutRect();

Nit: Could you just break directly here?
if (!isRectilinear())
    break;