[webkit-reviews] review denied: [Bug 119492] Implement SVGImage::hasSingleSecurityOrigin() : [Attachment 208363] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 8 19:09:42 PDT 2013
Darin Adler <darin at apple.com> has denied Timothy Hatcher <timothy at apple.com>'s
request for review:
Bug 119492: Implement SVGImage::hasSingleSecurityOrigin()
https://bugs.webkit.org/show_bug.cgi?id=119492
Attachment 208363: Patch
https://bugs.webkit.org/attachment.cgi?id=208363&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=208363&action=review
I’m sorry, not trying to be difficult, but I still say review-
> Source/WebCore/dom/Element.h:679
> + bool shouldProhibitLinks() const;
I’m sorry to be a broken record, but I still do not think this should be a
member function. I think a free function in HTMLAnchorElement.h would be
better. The other link-hosting classes can include HTMLAnchorElement.h to get
this.
More information about the webkit-reviews
mailing list