[webkit-reviews] review granted: [Bug 119607] navigator.plugins has plugins in it when plugins are disabled : [Attachment 208382] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 8 17:08:27 PDT 2013
Anders Carlsson <andersca at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 119607: navigator.plugins has plugins in it when plugins are disabled
https://bugs.webkit.org/show_bug.cgi?id=119607
Attachment 208382: patch
https://bugs.webkit.org/attachment.cgi?id=208382&action=review
------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=208382&action=review
> Source/WebKit/mac/WebCoreSupport/WebPlatformStrategies.mm:134
> + if (Frame* frame = page->mainFrame()) {
I don’t think Page::mainFrame can be null.
> Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:288
> + if (Frame* frame = page->mainFrame()) {
Ditto.
More information about the webkit-reviews
mailing list