[webkit-reviews] review granted: [Bug 116491] [WK2] loader/go-back-cached-main-resource.html fails : [Attachment 208364] proposed fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 8 13:42:38 PDT 2013


Tim Horton <thorton at apple.com> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 116491: [WK2] loader/go-back-cached-main-resource.html fails
https://bugs.webkit.org/show_bug.cgi?id=116491

Attachment 208364: proposed fix
https://bugs.webkit.org/attachment.cgi?id=208364&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=208364&action=review


> Tools/ChangeLog:17
> +	   Return last path component in cases where we used to return a full
path, which is
> +	   never desirable. Added a null check to basePath to prevent
potentially getting
> +	   an Objective C exception.

How does this not change more tests?


More information about the webkit-reviews mailing list