[webkit-reviews] review granted: [Bug 119586] [EME] Implement MediaKeys.isTypeSupported() : [Attachment 208357] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 119586: [EME] Implement MediaKeys.isTypeSupported()
https://bugs.webkit.org/show_bug.cgi?id=119586

Attachment 208357: Patch
https://bugs.webkit.org/attachment.cgi?id=208357&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=208357&action=review


> Source/WebCore/Modules/encryptedmedia/MediaKeys.cpp:135
> +    // 1. If keySystem contains an unrecognized or unsupported Key System,
return false and abort these steps.
> +    // Key system string comparison is case-sensitive.
> +    if (keySystem.isNull() || keySystem.isEmpty() ||
!CDM::supportsKeySystem(keySystem))
> +	   return false;
> +
> +    // 2. If type is null or an empty string, return true and abort these
steps.
> +    if (mimeType.isNull() || mimeType.isEmpty())
> +	   return true;
> +
> +    // 3. If the Key System specified by keySystem does not support
decrypting the container and/or codec
> +    // specified by type, return false and abort these steps.
> +    if (!CDM::supportsKeySystemAndMimeType(keySystem, mimeType))
> +	   return false;

Nit: it would be nice if this didn't have to ask the CDM if it supports the key
system twice.