[webkit-reviews] review granted: [Bug 119580] Move :optional/:required/:*range selector related virtuals off of Element. : [Attachment 208355] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 119580: Move :optional/:required/:*range selector related virtuals off of
Element.
https://bugs.webkit.org/show_bug.cgi?id=119580

Attachment 208355: Patch
https://bugs.webkit.org/attachment.cgi?id=208355&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=208355&action=review


> Source/WebCore/html/HTMLFormControlElement.h:70
> +    virtual bool isOptionalFormControl() const { return false; }
> +    virtual bool isRequiredFormControl() const { return false; }

Since these are moved down from Element to HTMLFormControlElement, they could
just be named isOptional and isRequired. The longer names were needed because
this was in Element.

>> Source/WebCore/html/HTMLSelectElement.h:149
>> +	virtual bool isOptionalFormControl() const OVERRIDE{ return
!isRequiredFormControl(); }
> 
> Missing space before {  [whitespace/braces] [5]

The stylebot, he’s right!