[webkit-reviews] review granted: [Bug 119578] Element: Modernize attribute storage accessor functions. : [Attachment 208352] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 119578: Element: Modernize attribute storage accessor functions.
https://bugs.webkit.org/show_bug.cgi?id=119578

Attachment 208352: Patch
https://bugs.webkit.org/attachment.cgi?id=208352&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=208352&action=review


Looks great, r=me

> Source/WebCore/dom/Element.cpp:1899
> -    return elementData()->getAttributeItem(shouldIgnoreAttributeCase(this) ?
localName.lower() : localName, false);
> +    return
elementData()->findAttributeByName(shouldIgnoreAttributeCase(this) ?
localName.lower() : localName, false);

Not your fault but this probably should be findAttributeByName(localName,
shouldIgnoreAttributeCase(this))