[webkit-reviews] review canceled: [Bug 99352] [GTK] [WebKit2] Add an 'authenticate' signal to WebKitWebView : [Attachment 208349] Final patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 8 09:23:40 PDT 2013


Brian Holt <brian.holt at samsung.com> has canceled Brian Holt
<brian.holt at samsung.com>'s request for review:
Bug 99352: [GTK] [WebKit2] Add an 'authenticate' signal to WebKitWebView
https://bugs.webkit.org/show_bug.cgi?id=99352

Attachment 208349: Final patch
https://bugs.webkit.org/attachment.cgi?id=208349&action=review

------- Additional Comments from Brian Holt <brian.holt at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=208349&action=review


All changes have been applied - Carlos could you take a last look if they're ok
and cq+?

> Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp:1428
> +	   if (authorization && !strcmp(authorization,
authExpectedAuthorization)) {

I tried g_strcmp0, but since authExpectedAuthorization is never NULL it always
returns true and never gets through to sending a challenge.


More information about the webkit-reviews mailing list