[webkit-reviews] review granted: [Bug 119568] Inserting multiple rules into an empty style sheet should avoid style recalc if possible. : [Attachment 208342] Totally rad patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 119568: Inserting multiple rules into an empty style sheet should avoid
style recalc if possible.
https://bugs.webkit.org/show_bug.cgi?id=119568

Attachment 208342: Totally rad patch
https://bugs.webkit.org/attachment.cgi?id=208342&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=208342&action=review


> Source/WebCore/css/CSSStyleSheet.h:89
> +    enum WhetherContentsWereClonedForMutation {
ContentsWereNotClonedForMutation = 0, ContentsWereClonedForMutation };

poetic!

> Source/WebCore/dom/DocumentStyleSheetCollection.h:74
> +    enum UpdateFlag { NoUpdate = 0, OptimizedUpdate, FullUpdate };

Does the = 0 do something here?

> Source/WebCore/dom/DocumentStyleSheetCollection.h:137
> +    // This is a mirror of m_activeAuthorStyleSheets that gets populated on
demand for activeStyleSheetsContains().
> +    mutable OwnPtr<HashSet<const CSSStyleSheet*>>
m_weakCopyOfActiveStyleSheetListForFastLookup;

Bit clunky but I don't have great suggestions.