[webkit-reviews] review granted: [Bug 116987] [GTK] [CMake] Add support for building TestWebKitAPI : [Attachment 203259] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 8 08:21:43 PDT 2013


Philippe Normand <pnormand at igalia.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 116987: [GTK] [CMake] Add support for building TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=116987

Attachment 203259: Patch
https://bugs.webkit.org/attachment.cgi?id=203259&action=review

------- Additional Comments from Philippe Normand <pnormand at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=203259&action=review


Ok LGTM, I just have a small question:

> Tools/TestWebKitAPI/PlatformGTK.cmake:39
> +    ../../Source/WebCore/platform/gtk/GOwnPtrGtk.cpp

Is this safe? Perhaps there's a WebCore DIR variable that could be used here?


More information about the webkit-reviews mailing list