[webkit-reviews] review granted: [Bug 119164] REGRESSION (r121551) Incorrect handling of invalid media query list. : [Attachment 208324] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Zalan Bujtas <zalan at apple.com>'s
request for review:
Bug 119164: REGRESSION (r121551) Incorrect handling of invalid media query
list.
https://bugs.webkit.org/show_bug.cgi?id=119164

Attachment 208324: Patch
https://bugs.webkit.org/attachment.cgi?id=208324&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=208324&action=review


r=me

> Source/WebCore/css/CSSParser.cpp:11502
> +    RuleList emptyRules;

I think it would be bit nicer to just have RuleList() in call sites.

> Source/WebCore/css/CSSParser.cpp:11510
> +    } else if (rules)
> +	   rule = StyleRuleMedia::create(media, *rules);
> +    else
> +	   rule = StyleRuleMedia::create(media, emptyRules);

Could combine these by using ternary operator rules ? *rules : RuleList()