[webkit-reviews] review denied: [Bug 118839] Crash in WTF::RefPtr<WebCore::SpaceSplitStringData>::operator UnspecifiedBoolType : [Attachment 208308] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 7 20:58:58 PDT 2013


Darin Adler <darin at apple.com> has denied Rob Buis <rwlbuis at gmail.com>'s request
for review:
Bug 118839: Crash in WTF::RefPtr<WebCore::SpaceSplitStringData>::operator
UnspecifiedBoolType
https://bugs.webkit.org/show_bug.cgi?id=118839

Attachment 208308: Patch
https://bugs.webkit.org/attachment.cgi?id=208308&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=208308&action=review


> Source/WebCore/svg/SVGStyledElement.cpp:334
> +	   if (!elementData())
> +	       ensureUniqueElementData();

This fix does not look right. The bug seems to be in
Element::classAttributeChanged and the fix should be there as well.


More information about the webkit-reviews mailing list