[webkit-reviews] review denied: [Bug 119326] Add support for KeyboardEvent.location attribute : [Attachment 207849] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Aug 7 13:51:55 PDT 2013
Benjamin Poulain <benjamin at webkit.org> has denied Christophe Dumez
<dchris at gmail.com>'s request for review:
Bug 119326: Add support for KeyboardEvent.location attribute
https://bugs.webkit.org/show_bug.cgi?id=119326
Attachment 207849: Patch
https://bugs.webkit.org/attachment.cgi?id=207849&action=review
------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
Looks reasonable to me.
r- because you kill all coverage of keyLocation by renaming everything to
location. IMHO, most of these tests should cover both location and the
deprecated keyLocation.
More information about the webkit-reviews
mailing list