[webkit-reviews] review granted: [Bug 119392] [Qt] REGRESSION(r) Two pixel result fail after r153522 : [Attachment 208196] Patch

[bugzilla-daemon at webkit.org]

Jocelyn Turcotte <jocelyn.turcotte at digia.com> has granted Allan Sandfeld Jensen
<allan.jensen at digia.com>'s request for review:
Bug 119392: [Qt] REGRESSION(r) Two pixel result fail after r153522
https://bugs.webkit.org/show_bug.cgi?id=119392

Attachment 208196: Patch
https://bugs.webkit.org/attachment.cgi?id=208196&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at digia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=208196&action=review


lgtm, some nitpicks but r=me anyway if you want to land directly.

> Source/WebCore/platform/graphics/qt/ImageQt.cpp:247
> +    if (transform.type() > QTransform::TxScale)

Nit: This breaks QTransform's abstraction by assuming details from the
implementation and requires opening qtransform.h to understand. Straight & and
| on the unsupported flags would be clearer.

> Source/WebCore/platform/graphics/qt/ImageQt.cpp:303
> +    image = prescaleImageIfRequired(ctxt->platformContext(), image,
&prescaledBuffer, normalizedDst, normalizedSrc);

Nit: Passing normalizedSrc as a QRectF* would make it clear from the call site
that there might be side effects on it.