[webkit-reviews] review denied: [Bug 108881] Canvas fillText and measureText handle ideographic spaces differently : [Attachment 208243] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Rashmi Shyamasundar
<rashmi.s2 at samsung.com>'s request for review:
Bug 108881: Canvas fillText and measureText handle ideographic spaces
differently
https://bugs.webkit.org/show_bug.cgi?id=108881

Attachment 208243: Patch
https://bugs.webkit.org/attachment.cgi?id=208243&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=208243&action=review


> Source/WebCore/ChangeLog:16
> +	   No new tests (OOPS!).

This is a hint that your patch needs a test. :)

> Source/WTF/wtf/text/StringImpl.h:1359
> +static inline bool shouldSpaceBeReplaced(UChar c)
> +{
> +    return (c == 0x0009 || c == 0x000A || c == 0x000C || c == 0x000D) ? true
: false;
> +}
> +

It seems like a layering violation for details of the canvas spec to be encoded
into the WTFString class.