[webkit-reviews] review denied: [Bug 118203] DFG should support ret_object_or_this : [Attachment 208210] Patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has denied Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 118203: DFG should support ret_object_or_this
https://bugs.webkit.org/show_bug.cgi?id=118203

Attachment 208210: Patch
https://bugs.webkit.org/attachment.cgi?id=208210&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=208210&action=review


> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:941
> +	   if (isObjectSpeculation(forNode(node->child1()).m_type))
> +	       m_state.setFoundConstants(true);

This should say:

if (isObjectBlah...) {
    forNode(node) = forNode(node->child1());
    setFoundConstants
    break;
}

Reason: if constant folding turns this into a node that does X, then this
should do exactly X.  Here X = Identity, right?