[webkit-reviews] review denied: [Bug 118526] [CSS Regions] Propagate overflow from the flow thread to the first and last region : [Attachment 207385] Patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Andrei Bucur <abucur at adobe.com>'s
request for review:
Bug 118526: [CSS Regions] Propagate overflow from the flow thread to the first
and last region
https://bugs.webkit.org/show_bug.cgi?id=118526

Attachment 207385: Patch
https://bugs.webkit.org/attachment.cgi?id=207385&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=207385&action=review


Looks good. Just fix the new argument to be an enum and it's good to go.

> Source/WebCore/rendering/RenderRegion.h:148
> +    LayoutRect overflowRectForFlowThreadPortion(const LayoutRect&
flowThreadPortionRect, bool isFirstPortion, bool isLastPortion, bool isVisual)
const;

Use an enum for the new argument please. The general rule is to use enums if
you're going to pass raw true/false at call sites so that the call sites aren't
confusing.