[webkit-reviews] review granted: [Bug 117762] Provide optional OTHER_CFLAGS, OTHER_CPPFLAGS, OTHER_LDFLAGS additions for building with ASAN : [Attachment 208152] Patch

[bugzilla-daemon at webkit.org]

Mark Rowe (bdash) <mrowe at apple.com> has granted David Farler
<dfarler at apple.com>'s request for review:
Bug 117762: Provide optional OTHER_CFLAGS, OTHER_CPPFLAGS, OTHER_LDFLAGS
additions for building with ASAN
https://bugs.webkit.org/show_bug.cgi?id=117762

Attachment 208152: Patch
https://bugs.webkit.org/attachment.cgi?id=208152&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=208152&action=review


> Tools/TestWebKitAPI/Configurations/DebugRelease.xcconfig:38
> +OTHER_CPLUSPLUSFLAGS = -ftemplate-depth=256 $(ASAN_OTHER_CPLUSPLUSFLAGS);

It's a little bit sad that we have to duplicate this here. I'm not sure there's
an alternative approach that's substantially better though.