[webkit-reviews] review denied: [Bug 118574] SVG stroke-dasharray is not animatable : [Attachment 208136] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied Rob Buis <rwlbuis at gmail.com>'s
request for review:
Bug 118574: SVG stroke-dasharray is not animatable
https://bugs.webkit.org/show_bug.cgi?id=118574

Attachment 208136: Patch
https://bugs.webkit.org/attachment.cgi?id=208136&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=208136&action=review


Looks great in general. Some notes inside.

> Source/WebCore/page/animation/CSSPropertyAnimation.cpp:236
> +    if (from.size() != to.size())
> +	   return to;

Do we really just want to animate lists of same length? I wonder if it would
make sense to 0 the other values.

> Source/WebCore/page/animation/CSSPropertyAnimation.cpp:238
> +    Vector<SVGLength> ret(len);

please use a more meaningful name. result?

> LayoutTests/transitions/svg-transitions.html:18
> +	 stroke-dasharray: 10 10;

more tests would be great. Especially with different values, length.