[webkit-reviews] review granted: [Bug 106198] PreloadScanner preloads external CSS with non-matching media attribute : [Attachment 197661] Preload external stylesheets according to their media attribute

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Yoav Weiss <yoav at yoav.ws>'s request
for review:
Bug 106198: PreloadScanner preloads external CSS with non-matching media
attribute
https://bugs.webkit.org/show_bug.cgi?id=106198

Attachment 197661: Preload external stylesheets according to their media
attribute
https://bugs.webkit.org/attachment.cgi?id=197661&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=197661&action=review


Looks ok. Just minor comments.

> Source/WebCore/ChangeLog:16
> +	   * html/parser/HTMLPreloadScanner.cpp:
> +	   (WebCore::TokenPreloadScanner::StartTagScanner::StartTagScanner):
> +	  
(WebCore::TokenPreloadScanner::StartTagScanner::createPreloadRequest):
> +	   (WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):
> +	   (WebCore::TokenPreloadScanner::StartTagScanner::resourceType):
> +	   (WebCore::TokenPreloadScanner::StartTagScanner::shouldPreload):
> +	   (TokenPreloadScanner::StartTagScanner):

I'd really like some per-function comments here to make it clear what you're
changing.

> Source/WebCore/html/parser/HTMLResourcePreloader.h:43
> +	   return adoptPtr(new PreloadRequest(initiator, resourceURL, baseURL,
resourceType, ""));

Use String() rather than "".