[webkit-reviews] review granted: [Bug 119462] Force elements with perspective or preserve-3d to disallow direct composited backgrounds : [Attachment 208053] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted  review:
Bug 119462: Force elements with perspective or preserve-3d to disallow direct
composited backgrounds
https://bugs.webkit.org/show_bug.cgi?id=119462

Attachment 208053: Patch
https://bugs.webkit.org/attachment.cgi?id=208053&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=208053&action=review


>>> Source/WebCore/rendering/RenderLayerBacking.cpp:1518
>>> +	     return false;
>> 
>> I think we need to do the same thing for simple image layers; they should
show the same bug.
> 
> Simple image layers can't have children, so nothing to intersect with.

True dat!

>
LayoutTests/compositing/background-color/no-composited-background-color-when-pe
rspective-expected.html:16
> +    background-image:
url("data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAUAAAAFCAMAAAC6sdbXAAAAGXRF
WHRTb2Z0d2FyZQBBZG9iZSBJbWFnZVJlYWR5ccllPAAAAAZQTFRFAAAA////pdmf3QAAAA5JREFUeNp
iYMAHAAIMAAAeAAHMILKLAAAAAElFTkSuQmCC");

This might fall into a future background-image optimization. Maybe better to
use border: 5px solid black and box-sizing: foo.