[webkit-reviews] review granted: [Bug 119390] Remove dependency on CoreFoundation from WebURLResponse : [Attachment 207913] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 119390: Remove dependency on CoreFoundation from WebURLResponse
https://bugs.webkit.org/show_bug.cgi?id=119390

Attachment 207913: Patch
https://bugs.webkit.org/attachment.cgi?id=207913&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=207913&action=review


This is really more a renaming than actually removing a dependency (I guess the
CFIndex type definition might have forced a CoreFoundation reference).	Looks
fine to me.  Was there a CoreFoundation include that could be removed here as
well?

> Source/WebKit/win/WebURLResponse.cpp:375
> +    String statusText = localizedShortDescriptionForStatusCode(statusCode);

Seems like this could be "const String& statusText" = ...; might allow
return-value-optimization.