[webkit-reviews] review granted: [Bug 119428] Removing an empty style sheet shouldn't trigger style recalc. : [Attachment 207982] Proposed patch v2

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 119428: Removing an empty style sheet shouldn't trigger style recalc.
https://bugs.webkit.org/show_bug.cgi?id=119428

Attachment 207982: Proposed patch v2
https://bugs.webkit.org/attachment.cgi?id=207982&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=207982&action=review


> Source/WebCore/css/CSSStyleSheet.h:77
> -    virtual void clearOwnerNode() OVERRIDE { didMutate(); m_ownerNode = 0; }

> +    virtual void clearOwnerNode() OVERRIDE;

didMutate() (and so this performance regression) was added here:
http://trac.webkit.org/changeset/144713

> Source/WebCore/dom/Document.h:200
> -enum StyleResolverUpdateFlag { RecalcStyleImmediately, DeferRecalcStyle,
RecalcStyleIfNeeded };
> +enum StyleResolverUpdateFlag { RecalcStyleImmediately, DeferRecalcStyle,
RecalcStyleIfNeeded, DeferRecalcStyleIfNeeded };

It is unfortunate that this gets even more complicated. It is hard to reason
from these.