[webkit-reviews] review denied: [Bug 119434] [CSS Background Blending] Specifying background-image and background-color with opaque image doesn't trigger blending : [Attachment 207989] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 2 01:05:53 PDT 2013
Dirk Schulze <krit at webkit.org> has denied Mihai Tica <mitica at adobe.com>'s
request for review:
Bug 119434: [CSS Background Blending] Specifying background-image and
background-color with opaque image doesn't trigger blending
https://bugs.webkit.org/show_bug.cgi?id=119434
Attachment 207989: Patch
https://bugs.webkit.org/attachment.cgi?id=207989&action=review
------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=207989&action=review
> LayoutTests/ChangeLog:12
> + *
css3/compositing/background-blend-mode-separate-layer-declaration.html: Added.
> + *
platform/mac/css3/compositing/background-blend-mode-separate-layer-declaration-
expected.png: Added.
> + *
platform/mac/css3/compositing/background-blend-mode-separate-layer-declaration-
expected.txt: Added.
Patch looks great! Can you please use an ref test instead of an pixel test? r-
until you added a ref test.
More information about the webkit-reviews
mailing list