[webkit-reviews] review granted: [Bug 119416] REGRESSION (r130783): Scrolling is broken going back to a cached page from a page that still has outstanding subresources : [Attachment 207973] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 1 20:28:05 PDT 2013


Darin Adler <darin at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 119416: REGRESSION (r130783): Scrolling is broken going back to a cached
page from a page that still has outstanding subresources
https://bugs.webkit.org/show_bug.cgi?id=119416

Attachment 207973: Patch v1 
https://bugs.webkit.org/attachment.cgi?id=207973&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=207973&action=review


r=me; I know you want to wait to see what Mac and Win EWS says, and I’m sure
you’ll get those results soon.

> Source/WebCore/loader/DocumentLoader.cpp:311
> +    if (Document* doc = document())
> +	   doc->cancelParsing();

When moving this it might be nice to get rid of the abbreviation too:

    if (Document* document = this->document())
	document->cancelParsing();


More information about the webkit-reviews mailing list