[webkit-reviews] review denied: [Bug 113753] Caret need not be moved to horizontal boundary when past top or bottom on Linux : [Attachment 196082] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied KyungTae Kim <ktf.kim at samsung.com>'s
request for review:
Bug 113753: Caret need not be moved to horizontal boundary when past top or
bottom on Linux
https://bugs.webkit.org/show_bug.cgi?id=113753

Attachment 196082: Patch
https://bugs.webkit.org/attachment.cgi?id=196082&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=196082&action=review


> Source/WebCore/ChangeLog:11
> +	   No new tests.

We definitely need tests. In fact, existing tests will start failing once this
patch is landed.

> Source/WebCore/editing/EditingBehavior.h:44
> -	   return m_type != EditingWindowsBehavior && m_type !=
EditingAndroidBehavior;
> +	   return m_type != EditingWindowsBehavior && m_type !=
EditingAndroidBehavior && m_type != EditingUnixBehavior;

It's probably better to check m_type == EditingMacBehavior instead.