[webkit-reviews] review denied: [Bug 119417] Use op_get_by_id_custom_stub to fast access to JSCallbackObject's static value : [Attachment 207971] proposal patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has denied Yi Shen
<max.hong.shen at gmail.com>'s request for review:
Bug 119417: Use op_get_by_id_custom_stub to fast access to JSCallbackObject's
static value
https://bugs.webkit.org/show_bug.cgi?id=119417

Attachment 207971: proposal patch
https://bugs.webkit.org/attachment.cgi?id=207971&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
This isn't quite right.

The API allows a client to specify an abstract hasProperty and/or getProperty
callback, and that callback is allowed to return different results every time,
making it incorrect to cache.

Please add a test to testapi that fails for this reason with your current
patch.

That said, you may be able to rescue the basic idea of this optimization: You
just need to modify your patch to be sure to poison all property access as
uncacheable if anything in the class or prototype hierarchy specifies an
abstract getProperty or hasProperty callback.