[webkit-reviews] review granted: [Bug 119415] [Windows] WebKit1 Full Screen Video Play on Windows is Broken : [Attachment 207967] Patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 119415: [Windows] WebKit1 Full Screen Video Play on Windows is Broken
https://bugs.webkit.org/show_bug.cgi?id=119415

Attachment 207967: Patch
https://bugs.webkit.org/attachment.cgi?id=207967&action=review

------- Additional Comments from Jer Noble <jer.noble at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=207967&action=review


> Source/WebCore/platform/graphics/ca/win/WKCACFViewLayerTreeHost.h:42
> +    virtual bool manualCreateRenderer() { return createRenderer(); }
> +

We should just make createRenderer() public rather than make a public alias.

>
Source/WebCore/platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:82
> -    ::CreateWindowExW(WS_EX_TOOLWINDOW, windowClassName, L"", WS_POPUP, 
> +    m_hwnd = ::CreateWindowExW(WS_EX_TOOLWINDOW, windowClassName, L"",
WS_POPUP, 

This isn't necessary as m_hwnd will be set in a WM_CREATE message during this
call. (That's what the ASSERT below is checking.)

Other than those nits, LGTM.