[webkit-reviews] review granted: [Bug 115448] ipc-posix-shm backwards compatibility : [Attachment 200194] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Simon Cooper
<scooper at apple.com>'s request for review:
Bug 115448: ipc-posix-shm backwards compatibility
https://bugs.webkit.org/show_bug.cgi?id=115448

Attachment 200194: Patch
https://bugs.webkit.org/attachment.cgi?id=200194&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=200194&action=review


r=me

>
Source/WebKit2/Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.s
b:250
> +(if (not (defined? 'ipc-posix-shm*))
> +    (define ipc-posix-shm* ipc-posix-shm))

I wish we pre-processed plug-in sandbox profile files, so that we could do
conditional compilation. With an #if check, removing obsolete code is much more
straightforward.

Also, we wouldn't have to merge parts at runtime, as we could simply #include
"com.apple.WebKit.plugin-common.sb", and let preprocessor build a complete
profile.