[webkit-reviews] review granted: [Bug 115285] [webkitpy] suggest-nominations doesn't count all qualified patches : [Attachment 200079] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 30 17:01:34 PDT 2013


Benjamin Poulain <benjamin at webkit.org> has granted Glenn Adams
<glenn at skynav.com>'s request for review:
Bug 115285: [webkitpy] suggest-nominations doesn't count all qualified patches
https://bugs.webkit.org/show_bug.cgi?id=115285

Attachment 200079: Patch
https://bugs.webkit.org/attachment.cgi?id=200079&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=200079&action=review


I would really prefer the callback approach to be cleaned but I am too tired to
fight.

> Tools/Scripts/webkitpy/tool/commands/suggestnominations.py:40
> +

Blank line.

> Tools/Scripts/webkitpy/tool/commands/suggestnominations.py:46
> +

Blank line.

> Tools/Scripts/webkitpy/tool/commands/suggestnominations.py:53
> -    help_text = "Suggest contributors for committer/reviewer nominations"
> +    help_text = "Suggest nominations for committer/reviewer role"

I think the previous text is better.

The patch count is only a lower limit. You can have thousands of patches and
not be nominated.

> Tools/Scripts/webkitpy/tool/commands/suggestnominations.py:126
> +	   if not author_match:
> +	       raise CommitLogError

How could this happen?
We could not get here if committer_match is None.

> Tools/Scripts/webkitpy/tool/commands/suggestnominations.py:132
> +	   if not author_email:
> +	       raise CommitLogError

ditto


More information about the webkit-reviews mailing list