[webkit-reviews] review granted: [Bug 115300] fourthTier: DFG tries to ref/deref StringImpls in a ton of places : [Attachment 200151] the patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 115300: fourthTier: DFG tries to ref/deref StringImpls in a ton of places
https://bugs.webkit.org/show_bug.cgi?id=115300

Attachment 200151: the patch
https://bugs.webkit.org/attachment.cgi?id=200151&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=200151&action=review


r=me

> Source/JavaScriptCore/runtime/Identifier.h:251
> +    typedef HashMap<StringImpl*, int, IdentifierRepHash,
HashTraits<StringImpl*>, IdentifierMapIndexHashTraits> ConcurrentIdentifierMap;


Maybe BorrowedIdentifierMap instead? I don't love "Concurrent" in the name
because it might imply safety.