[webkit-reviews] review requested: [Bug 98840] [WebSocket] Add permessage-compress extension : [Attachment 200147] Patch

[bugzilla-daemon at webkit.org]

Lamarque V. Souza <Lamarque.Souza at basyskom.com> has asked  for review:
Bug 98840: [WebSocket] Add permessage-compress extension
https://bugs.webkit.org/show_bug.cgi?id=98840

Attachment 200147: Patch
https://bugs.webkit.org/attachment.cgi?id=200147&action=review

------- Additional Comments from Lamarque V. Souza
<Lamarque.Souza at basyskom.com>
Patch rebased on top of current git revision. I have updated the unit tests as
well, only permessage-compress-parameter.html (former
deflate-frame-parameter.html) still does not work properly because
WebSocket.extensions does not return method parameters (c2s_max_window_bits or
c2s_no_context_takeover for instance), only server parameters (method=deflate).
CompressionMessageExtensionProcessor::processResponse() is the place where
server parameters and method parameters are parsed, with deflate-framer
extension they are mixed, now they are split but there is no javascript method
that can return method parameters so they can be unit tested in javascript.
This patch is a working in progress, the ChangeLog still needs updating and I
would like someone else to review the usage of
m_perMessageCompression.resetCompressBuffer() and
m_perMessageCompression.resetDecompressBuffer() in WebSocketChannel.cpp,
specially if there are any other place they are needed.