[webkit-reviews] review denied: [Bug 115397] [ARM] REGRESSION(r149349): It broke Octane/Crypto : [Attachment 200089] Patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has denied  review:
Bug 115397: [ARM] REGRESSION(r149349): It broke Octane/Crypto
https://bugs.webkit.org/show_bug.cgi?id=115397

Attachment 200089: Patch
https://bugs.webkit.org/attachment.cgi?id=200089&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
Yeah, I think this is still wrong.  GPRResult is for forcing the return
register to be live across a call to flushRegisters(), when you're making an
unconditional call that clobbers all registers.  It looks like you're doing an
unconditional register-clobbering call if !supportsIntegerDiv().  So, this will
still break things.  I think you need to use GPRResult if !supportsIntegerDiv()
and GPRTemporary otherwise.