[webkit-reviews] review granted: [Bug 115418] Stop using "in" keyword in IDL files : [Attachment 200106] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 30 06:40:38 PDT 2013


Kentaro Hara <haraken at chromium.org> has granted Christophe Dumez
<dchris at gmail.com>'s request for review:
Bug 115418: Stop using "in" keyword in IDL files
https://bugs.webkit.org/show_bug.cgi?id=115418

Attachment 200106: Patch
https://bugs.webkit.org/attachment.cgi?id=200106&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
I'd encourage you to land the patch excluding the change in IDLParser.pm. As
long as you remove 'in' from WebKit IDL files, it won't break anything.
However, removing the 'in' support from IDLParser.pm will break Safari's
internal build. You can make the change in a follow-up patch, discussing with
timo@ and timothy at .


More information about the webkit-reviews mailing list