[webkit-reviews] review denied: [Bug 113949] [EFL] --minimal build fails with error: invalid use of incomplete type `class WebKit::WebContextMenuItemData' : [Attachment 200027] Patch

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at samsung.com> has denied Ed Bartosh
<bartosh at gmail.com>'s request for review:
Bug 113949: [EFL] --minimal build fails with error: invalid use of incomplete
type `class WebKit::WebContextMenuItemData'
https://bugs.webkit.org/show_bug.cgi?id=113949

Attachment 200027: Patch
https://bugs.webkit.org/attachment.cgi?id=200027&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=200027&action=review


> Source/WebKit2/UIProcess/API/efl/ewk_context_menu.cpp:-166
> -static WKContextMenuItemTag
getWKTagFromEwkAction(Ewk_Context_Menu_Item_Action action)

Why do you remove this function ?

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:117
> +#if ENABLE(CONTEXT_MENUS)

Please don't use ENABLE() in public header.

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:178
> +#if ENABLE(CONTEXT_MENUS)

ditto.