[webkit-reviews] review granted: [Bug 115398] Simplify ContainerNode::removeChildren : [Attachment 200087] Cleanup

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 115398: Simplify ContainerNode::removeChildren
https://bugs.webkit.org/show_bug.cgi?id=115398

Attachment 200087: Cleanup
https://bugs.webkit.org/attachment.cgi?id=200087&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=200087&action=review


> Source/WebCore/dom/ContainerNode.cpp:610
> -    Vector<RefPtr<Node>, 10> removedChildren;
> +    NodeVector removedChildren;

I think we should get rid of the NodeVector typedef, or at least give it a less
silly default capacity.
Since it's always on the stack, we can just as well go with 16, 32 or 64.
The goal is presumably to avoid having to allocate a heap buffer, so why not
try a little harder?