[webkit-reviews] review granted: [Bug 115389] It should be an error to use adoptPtr with RefCounted subclasses : [Attachment 200063] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 115389: It should be an error to use adoptPtr with RefCounted subclasses
https://bugs.webkit.org/show_bug.cgi?id=115389

Attachment 200063: Patch
https://bugs.webkit.org/attachment.cgi?id=200063&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=200063&action=review


I loooove this. Great idea.

> Source/WTF/wtf/PassOwnPtr.h:151
> +	   COMPILE_ASSERT(!(IsSubclass<T, RefCounted<T> >::value),
DoNotUseAdoptPtrWithRefCounted);
> +	   COMPILE_ASSERT(!(IsSubclass<T, ThreadSafeRefCounted<T> >::value),
DoNotUseAdoptPtrWithThreadSafeRefCounted);

+RefCountedBase