[webkit-reviews] review denied: [Bug 115285] [webkitpy] suggest-nominations doesn't count all qualified patches : [Attachment 200055] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Glenn Adams <glenn at skynav.com>'s
request for review:
Bug 115285: [webkitpy] suggest-nominations doesn't count all qualified patches
https://bugs.webkit.org/show_bug.cgi?id=115285

Attachment 200055: Patch
https://bugs.webkit.org/attachment.cgi?id=200055&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=200055&action=review


> Tools/Scripts/webkitpy/tool/commands/suggestnominations.py:99
> +	   # Determine committer if possible, otherwise skip commit.

We should share code with ChangeLogEntry as I mentioned earlier. r-.

> Tools/Scripts/webkitpy/tool/commands/suggestnominations.py:160
> +	   on_analysis(analysis, committer, commit_date, revision,
author_email, author_name, contributor, reviewers)

Why do we need a callback function?