[webkit-reviews] review granted: [Bug 115330] Need a LayoutMilestone to fire when we have done our first paint after suppressing incremental layout : [Attachment 200043] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 29 14:11:16 PDT 2013


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Beth Dakin
<bdakin at apple.com>'s request for review:
Bug 115330: Need a LayoutMilestone to fire when we have done our first paint
after suppressing incremental layout
https://bugs.webkit.org/show_bug.cgi?id=115330

Attachment 200043: Patch
https://bugs.webkit.org/attachment.cgi?id=200043&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=200043&action=review


> Source/WebCore/page/FrameView.cpp:3567
> +    if (Page* page = m_frame->page()) {
> +	   if (m_milestonesPendingPaint &
DidFirstPaintAfterSuppressedIncrementalRendering) {
> +	      
removePaintPendingMilestones(DidFirstPaintAfterSuppressedIncrementalRendering);

> +	       if (page->requestedLayoutMilestones() &
DidFirstPaintAfterSuppressedIncrementalRendering)
> +		  
frame()->loader()->didLayout(DidFirstPaintAfterSuppressedIncrementalRendering);

> +	   }
> +    }

It would be nice to wrap up the "remove and fire" code here and in
RenderLayerCompositor into one place.


More information about the webkit-reviews mailing list