[webkit-reviews] review requested: [Bug 115263] Remove all remaining Skia code : [Attachment 200042] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Apr 29 13:28:10 PDT 2013
Alberto Garcia <agarcia at igalia.com> has asked for review:
Bug 115263: Remove all remaining Skia code
https://bugs.webkit.org/show_bug.cgi?id=115263
Attachment 200042: Patch
https://bugs.webkit.org/attachment.cgi?id=200042&action=review
------- Additional Comments from Alberto Garcia <agarcia at igalia.com>
This patch removes almost all remaining references to Skia.
A couple of comments:
- FrameLoaderClientBlackBerry.cpp still contains some Skia code, but
I'm not removing it now. Soon I'll upstream the most recent version
of that file, which is significantly different from this one.
- I didn't remove LayoutTests/fast/canvas/canvas-skia-excessive-size.
This test checks whether the browser can handle the creation of an
excessively large canvas, which sounds like a useful test in
general. Maybe we can rename it?
- Other Skia tests: svg/custom/image-rescale-clip.html
svg/custom/image-rescale-scroll.html
These come from bug 42370, "Scaled Resized images are blurred when
sent to Skia". I didn't touch them in this patch, but I'm not sure
if they are really interesting to keep.
More information about the webkit-reviews
mailing list