[webkit-reviews] review denied: [Bug 80712] [CSS Regions] Convert some fast/regions pixel tests to reftests : [Attachment 200005] Patch

[bugzilla-daemon at webkit.org]

Alexandru Chiculita <achicu at adobe.com> has denied Radu Stavila
<stavila at adobe.com>'s request for review:
Bug 80712: [CSS Regions] Convert some fast/regions pixel tests to reftests
https://bugs.webkit.org/show_bug.cgi?id=80712

Attachment 200005: Patch
https://bugs.webkit.org/attachment.cgi?id=200005&action=review

------- Additional Comments from Alexandru Chiculita <achicu at adobe.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=200005&action=review


Thanks, looks good! I have a couple of hints below. The comments apply for both
html files.

>
LayoutTests/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.htm
l:5
> +	text-align: justify;

nit: you have different indentation styles in the style elements.

>
LayoutTests/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.htm
l:87
> +	   margin-top: -22px;

<p> tags have margin-top/bottom set using "em" units.  I think you could avoid
using <p> tags or set the margins to 0 to avoid having to compensate for it in
the parent box. Setting the margin this way makes the ref-test fragile when
changing the default font-size.