[webkit-reviews] review granted: [Bug 115320] Unifty the data access of StringImpl members from JavaScriptCore : [Attachment 199958] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 29 06:40:49 PDT 2013


Andreas Kling <akling at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 115320: Unifty the data access of StringImpl members from JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=115320

Attachment 199958: Patch
https://bugs.webkit.org/attachment.cgi?id=199958&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=199958&action=review


Cute cleanup.

> Source/JavaScriptCore/ChangeLog:3
> +	   Unifty the data access of StringImpl members from JavaScriptCore

Unifty -> Unify

> Source/JavaScriptCore/ChangeLog:9
> +	   DFG access the member infos by directly calling the methods on
StringImpl,
> +	   while the baseline JIT was using helper methods on ThunkHelpers.

access -> accesses


More information about the webkit-reviews mailing list