[webkit-reviews] review granted: [Bug 115325] Remove Chromium code from Tools/BuildSlaveSupport : [Attachment 199963] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Apr 28 15:35:15 PDT 2013
Benjamin Poulain <benjamin at webkit.org> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 115325: Remove Chromium code from Tools/BuildSlaveSupport
https://bugs.webkit.org/show_bug.cgi?id=115325
Attachment 199963: Patch
https://bugs.webkit.org/attachment.cgi?id=199963&action=review
------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=199963&action=review
Gosh, we keep cleaning and you keep finding crap everywhere :(
> Tools/BuildSlaveSupport/built-product-archive:95
> -
> - # Chromium bots may not have this directory
> if not os.path.isdir(archiveDir):
> os.mkdir(archiveDir)
Shouldn't the if go away?
If the comment is correct, it has become useless.
More information about the webkit-reviews
mailing list