[webkit-reviews] review granted: [Bug 115334] [WebKit2] Adopt new API for detecting window occlusion : [Attachment 199970] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Sam Weinig
<sam at webkit.org>'s request for review:
Bug 115334: [WebKit2] Adopt new API for detecting window occlusion
https://bugs.webkit.org/show_bug.cgi?id=115334

Attachment 199970: Patch
https://bugs.webkit.org/attachment.cgi?id=199970&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=199970&action=review


> Source/WebKit2/UIProcess/API/mac/PageClientImpl.mm:213
> +#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090
>      if ([m_wkView _isWindowOccluded])
>	   return false;
> +#endif

It would be slightly cleaner to have _isWindowOccluded pre-10.9 and just always
return false.