[webkit-reviews] review denied: [Bug 115330] Need a LayoutMilestone to fire when we have done our first paint after suppressing incremental layout : [Attachment 199967] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Beth Dakin
<bdakin at apple.com>'s request for review:
Bug 115330: Need a LayoutMilestone to fire when we have done our first paint
after suppressing incremental layout
https://bugs.webkit.org/show_bug.cgi?id=115330

Attachment 199967: Patch
https://bugs.webkit.org/attachment.cgi?id=199967&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=199967&action=review


> Source/WebCore/dom/Document.cpp:1302
>      if (renderer())
>	   renderer()->repaint();

This is so bogus. It doesn't cause compositing layers to paint.

> Source/WebCore/dom/Document.cpp:1305
> +    if (page()->requestedLayoutMilestones() &
DidFirstPaintAfterSuppressedIncrementalRendering)
> +	  
frame()->loader()->didLayout(DidFirstPaintAfterSuppressedIncrementalRendering);


There's some irony here: didLayout(DidFirstPaint... (layout vs. paint).

And I think this is wrong. I think you need to wait for the first compositing
layer flush after this, especially since we have logic to suppress compositing
layer flushes.

> Source/WebCore/page/LayoutMilestones.h:36
> +    DidFirstPaintAfterSuppressedIncrementalRendering = 1 << 4

Many of our so-called layout milestones are more about painting :-\