[webkit-reviews] review denied: [Bug 115303] Assertion while scrolling news.google.com : [Attachment 199957] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Apr 28 11:38:17 PDT 2013


Simon Fraser (smfr) <simon.fraser at apple.com> has denied Jonathan Liu
<net147 at gmail.com>'s request for review:
Bug 115303: Assertion while scrolling news.google.com
https://bugs.webkit.org/show_bug.cgi?id=115303

Attachment 199957: Patch
https://bugs.webkit.org/attachment.cgi?id=199957&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
I think this is just papering over the cracks. It's wrong for
updateStyleIfNeeded() to get called during painting, period. Yes, plugins that
run script when being painted can cause this. They are evil plugins, but we
can't stop them.

Mac has a code path that paints plugins into bitmaps earlier, and then paints
those bitmaps during the painting code. Maybe Qt needs the  same thing.


More information about the webkit-reviews mailing list