[webkit-reviews] review granted: [Bug 115314] Simplify WebHTMLRepresentation supportedMIMETypes methods : [Attachment 199920] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Apr 27 19:35:23 PDT 2013
Darin Adler <darin at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 115314: Simplify WebHTMLRepresentation supportedMIMETypes methods
https://bugs.webkit.org/show_bug.cgi?id=115314
Attachment 199920: Patch
https://bugs.webkit.org/attachment.cgi?id=199920&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=199920&action=review
> Source/WebKit/mac/WebView/WebHTMLRepresentation.mm:87
> +static NSMutableArray *createArrayWithStrings(const HashSet<String>& set)
It would be nice to use naming that tells the static analyzer this object is
intentionally leaked. Or we could name this leak like we do other similar
functions.
More information about the webkit-reviews
mailing list