[webkit-reviews] review granted: [Bug 115270] [WKTR] Tests dumping audio data shouldn't dump pixels : [Attachment 199850] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Apr 27 18:33:10 PDT 2013
Benjamin Poulain <benjamin at webkit.org> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 115270: [WKTR] Tests dumping audio data shouldn't dump pixels
https://bugs.webkit.org/show_bug.cgi?id=115270
Attachment 199850: Patch
https://bugs.webkit.org/attachment.cgi?id=199850&action=review
------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=199850&action=review
> Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp:383
> WKRetainPtr<WKDataRef> audioData(AdoptWK,
WKBundleCreateWKDataFromUInt8Array(InjectedBundle::shared().bundle(), context,
data));
> InjectedBundle::shared().setAudioResult(audioData.get());
> m_whatToDump = Audio;
> + m_dumpPixels = false;
Maybe rename setAudioData to setAudioResult?
More information about the webkit-reviews
mailing list