[webkit-reviews] review granted: [Bug 115309] Replace uses of StorageTask with StorageThread::dispatch and WTF::bind : [Attachment 199910] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Apr 27 13:27:03 PDT 2013


Andreas Kling <akling at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 115309: Replace uses of StorageTask with StorageThread::dispatch and
WTF::bind
https://bugs.webkit.org/show_bug.cgi?id=115309

Attachment 199910: Patch
https://bugs.webkit.org/attachment.cgi?id=199910&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=199910&action=review


r=me

> Source/WebCore/storage/StorageTask.cpp:94
>	       break;

This line should also be removed.

> Source/WebCore/storage/StorageTracker.cpp:391
> +    m_thread->dispatch(bind(&StorageTracker::syncDeleteAllOrigins, this));

Dispatching a "sync" method sure looks odd.


More information about the webkit-reviews mailing list